Klockwork issue in timers.c

travfrog wrote on Friday, November 02, 2012:

Hi all,

We run Klockwork on our code base - a static code analysis tool. It complains about a possible NULL pointer deference in the function prvProcessReceivedCommands in timers.c.

In trying to follow the code through to see if this is at all possible, I came across a comment on line 508 that talks about a timer command, trmCOMMAND_PROCESS_TIMER_OVERFLOW which does not appear to exist in the code. This implies that the logic following on 511 will always run since there does not appear to be any time when the pxTimer is set to NULL.

Is this just code and/or comments left over from prior releases of FreeRTOS or am I missing something?

Many thanks
Richard Jackson

rtel wrote on Friday, November 02, 2012:

I’ve just had a look at this and don’t think you are missing something.  The code looks obsolete (although benign) and has been removed.

Thanks and regards.