xQueueSendFromISR(xQueue, &buffer, NULL) is this API will disable interrupts?

Kernel
1

Dear Community,

I am facing data missing probelm on UART. UART serial buffer losing some bytes when xQueueSendFromISR called from UART Rx ISR. Basically it is request and response communication over uart. response will come in 2 parts. after receiving the first part, called xQueueSendFromISR from UART Rx ISR. at the the same time 2nd part of response will receive. Also Data seeing by tapping UART Rx line, same is not receiving/seeing in UART Rx buffer (ISR Rx circular buffer)
Is xQueueSendFromISR will disable all the interrupts?

Other way i tried not calling xQueueSendFromISR, keeping rxflag, this time could not see the data bytes missed.

Target : RH850
Compiler: CC-RH
FreeRTOS Environments.

best regards,
msr

2

Please post an outline of your ISR.

3

Dear rtel,

We are using 3 uarts in interrupt mode, 2 are connected to modem communication. Another one debug logging. One uart get data (size - 64bytes) for every 1 sec will be received in uart rx isr and from there data will be pushed to queue (xQueueSendFromISR(xQueue, &buffer, NULL) ).
second uart used for req and response communication, response will be received in 2 messages. one after one. first message received and pushed to queue during push the data into queue second message not able to receive by the uart serial buffer. if i remove xQueueSendFromISR from isr function i can be able to see data in uart rx isr circular buffer. Suspecting xQueueSendFromISR will disable the interrupts during data push into queue because of that few of the bytes missing in uart rx ISR

br,msr

4

Where is this serial buffer?

Are you saying that the Rx ISR is getting lost? How did you verify that? As Richard said before, it would help if you share your ISR code.

5

There is a chance of your circular isr buffer being too small so that the buffer is overwritten before the signalled tasks have a chance to copy the data into application space. Also, do you monitor the hardware error flags (overrun, parity and frame errors) in your isr?

Again, without seeing code, everything is guess work.

6

Dear Gauravu

serial buffer nothing but uart peripheral special function register. like RLN30.LURDR.UINT16 in rh850
Uart RX ISR circular buffer size is 2KB.

code:

void r_UART_interrupt_receive(void){
	
   	resp_buf_U0[resp_wptr_U0] = RLN30.LURDR.UINT16;
	resp_wptr_U0 = (resp_wptr_U0+1 ) & (U0_RXFIFO_SIZE- 1);

	resp_pkt_isr.resp_buf[resp_pkt_isr.resp_len++] = resp_buf_U0[resp_rptr_U0] ;		
	resp_rptr_U0 =(resp_rptr_U0+1) & (U0_RXFIFO_SIZE - 1);

	if((resp_pkt_isr.resp_len >= RESP_LEN)){
		resp_pkt_isr.resp_buf[resp_pkt_isr.resp_len++] = 0x00; //NULL termination
		xQueueSendFromISR(xQueue, &resp_pkt_isr, NULL);
		resp_pkt_isr.resp_len = 0;
		memset(&resp_pkt_isr.resp_buf[0], 0x00, sizeof(resp_pkt_isr));
		return;
	}
 }
 
 void x_task(void *pvParameters){
 
 xStatus = xQueueReceive(xQueue, &resp_pkt_drv, 0);
		if( xStatus == pdPASS ){
               -----------------------
               } 
 }

if i comment xQueueSendFromISR from ISR, i can be able to see data in resp_buf_U0

7

Note, you are sending via the queue the ADDRESS of the resp_pkt_isr structure, so that is what the receiving task will get, the ADDRESS of the structure. Then you immediately clear the structure before the task can do anything with it, so of course the task can’t see what was there.

You either need to send the whole structure, which will be a lot of data copying, or you need to have a list of these packet buffers, so you can send one to the task to process while you are filling another.

1 Like
8

resp_pkt_isr seems to be the object and not the pointer. So passing &resp_pkt_isr should copy the object, assuming the queue item size (as given at the time of queue creation) is correct.

@srinivasa Is it possible for you to share complete code? May be put it somewhere in GitHub and share a link?