Type definitions in portmacro.h of RISC-V port?

Kernel
1

kj-lin wrote on Wednesday, September 25, 2019:

We found that it will get “unknown type name ‘portDOUBLE’” error while compiling “Common/Full/flop.c” or “Common/Minimal/flop.c” files in FreeRTOS RISC-V port.
This is due to that there is no “portDOUBLE” definition in portmacro.h of RISC-V port.
Should the following type definitions being added to RISC-V port’s portmacro.h file?

/* Type definitions. */
#define portCHAR                char
#define portFLOAT               float
#define portDOUBLE              double
#define portLONG                long
#define portSHORT               short
2

rtel wrote on Wednesday, September 25, 2019:

These are legacy definitions that date back to original FreeRTOS
versions - they are not used anywhere in the kernel itself. Really the
mistake here is that they are still used in the flop.c source file. I
have added them into both the GCC and IAR RISC-V ports none the less -
not checked in yet though.