ISR handling with PIOs

nobody wrote on Tuesday, May 10, 2005:

Hello!

I am having problems with getting the PIO interrupt to work properly. I have made a wrapping function in assembler and the interrupt is called properly, but when processor is about to leave the ISR and the portRESTORE_CONTEXT is called I get a data abort exception. Why is this?? My ISR is pasted below:

__arm void pio_ISR( void )
{
  portCHAR cContextSwitchRequired;

        int dummy;
        dummy = AT91C_BASE_PIOA->PIO_ISR;
        dummy=dummy; //Suppress compiler warning
        //* Read the output state
        if ( (AT91F_PIO_GetInput(AT91C_BASE_PIOA) &  INPUT_SERVO2_CAP) ==  INPUT_SERVO2_CAP); //Don’t do anything, rising edge
        else  //Falling edge -> capture value in
        {
          measure.duty_channel_2 = TimerBaseCPWM->TC_CV;
        }

        cContextSwitchRequired = pdFALSE;
       
        portEND_SWITCHING_ISR( ( cContextSwitchRequired ) );

        /* End the interrupt in the AIC. */
        AT91C_BASE_AIC->AIC_EOICR = 0;
}

Interrupt initialization:

      AT91F_PIO_CfgInput(AT91C_BASE_PIOA, INPUT_SERVO2_CAP);
       AT91F_AIC_ConfigureIt (AT91C_BASE_AIC, AT91C_ID_PIOA, PIO_INTERRUPT_LEVEL, AT91C_AIC_SRCTYPE_INT_LEVEL_SENSITIVE, ( void (*)( void ) ) pio_ISREntry);
       AT91F_PIO_InterruptEnable(AT91C_BASE_PIOA, INPUT_SERVO2_CAP);
       //* set the interrupt by software
       AT91F_AIC_EnableIt (AT91C_BASE_AIC, AT91C_ID_PIOA);

Wrapping file:
        RSEG ICODE:CODE
        CODE32

        EXTERN pio_ISR
        PUBLIC pio_ISREntry

; Wrapper for the USB interrupt service routine.  This can cause a
; context switch so requires an assembly wrapper.

; Defines the portSAVE_CONTEXT and portRESTORE_CONTEXT macros.
#include "ISR_Support.h"

pio_ISREntry:

    portSAVE_CONTEXT            ; Save the context of the current task.

    bl    pio_ISR                ; Call the ISR routine.

    portRESTORE_CONTEXT            ; Restore the context of the current task -
                                ; which may be different to the task that
                                ; was interrupted.

        END

Thanks in advance!
//MB

rtel wrote on Wednesday, May 11, 2005:

I cannot see anything obviously wrong by looking at the code.  Unfortunately I will not be able to try it until Sunday but here are a couple of pointers:

+ Could it be a stack problem?  Try increasing the stack size a bit - or inspecting the stack in the debugger.

+ Currently the code is always set to pass false to portEND_SWITCHING_ISR.  If you are not wanting to cause a context switch from within the ISR then you do not require any special syntax, and the standard IAR syntax can be used.  You also then dont then require the wrapper either (see the "interrupt service routines" section of http://www.freertos.org/portsam7iar.html for detail). 

Even if you are intending on adding a context switch within the ISR at a later time it might be worth trying it without the wrapper to start with to check that there is nothing else wrong.

Let me know how you get on.  If you are still having problems on Sunday I should  be able to setup a test.

Regards.

nobody wrote on Thursday, May 12, 2005:

I tried to increase stack size without success, when I try the standard syntax it will enter the ISR but never leave it. Problem seems to be that when it tries to leave ISR it jumps back to top of ISR. It seems like the stack pointer gets lost somewhere?!

rtel wrote on Thursday, May 12, 2005:

Would it be possible to send me a small project that demonstrates the problem?  The smallest amount of code that still has the problem, along with the IAR project file.  I could then test to see if I can identify the solution.

If so please you the email address from the contact page of the FreeRTOS.org WEB site (r.barry at …) as the SourceForge address will strip the attachment.

Regards.