I am facing a compiler warning that I would like to ensure is not an error (directories have been scubbed):
/FreeRTOS-Plus-TCP/portable/NetworkInterface/STM32Fxx/NetworkInterface.c:82: warning: "ipFRAGMENT_OFFSET_BIT_MASK" redefined
82 | #define ipFRAGMENT_OFFSET_BIT_MASK ( ( uint16_t ) 0x0fff ) /* The bits in the two byte IP header field that make up the fragment offset value. */
|
In file included from /FreeRTOS-Plus-TCP/portable/NetworkInterface/STM32Fxx/NetworkInterface.c:45:
/FreeRTOS-Plus-TCP/include/FreeRTOS_IP_Private.h:346: note: this is the location of the previous definition
346 | #define ipFRAGMENT_OFFSET_BIT_MASK ( ( uint16_t ) 0xff1fU )
|
My lack of knowledge about this port makes me concerned about whether or not the definition in NetworkInterface.c is actually legit, if not perhaps it should be removed, otherwise guard the definition in FreeRTOS_IP_Private.h?
@htibosch While we’re at it, I was a bit confused about the #if ( ipconfigETHERNET_DRIVER_FILTERS_PACKETS == 0 )
condition still in FreeRTOS+TCP V2.3.3 bundled with FreeRTOS 202107.00 at the time I migrated to it and had to patch FreeRTOS_IP_Private.h again to make use exactly of those definitions in my MAC driver packet filter with ipconfigETHERNET_DRIVER_FILTERS_PACKETS enabled.
However, seems that it’s finally cleanup up in the latest/coming version. Thanks
include/FreeRTOS_IP_Private.h:346: note: this is the location of the previous definition 346 | #define ipFRAGMENT_OFFSET_BIT_MASK ( ( uint16_t ) 0xff1fU )
My lack of knowledge about this port makes me concerned about whether or not the definition in NetworkInterface.c is actually legit, if not perhaps it should be removed, otherwise guard the definition in FreeRTOS_IP_Private.h?
The macro ipFRAGMENT_OFFSET_BIT_MASK used to be defined in FreeRTOS_IP.c and in mentioned network interface. In January the define was moved to FreeRTOS_IP_Private.h, thanks to PR #179.
